Move crds to templates folder #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedjak
approved these changes
Sep 19, 2024
pedjak
approved these changes
Sep 19, 2024
bashofmann
reviewed
Sep 20, 2024
- Update makefile to add a conditional block to the qdrantversions template - Add parameter to the chart values - Remove duplicated qdrantversions.yaml file
bashofmann
force-pushed
the
chore/toni/move-crds-to-templates
branch
from
737bdad to
00e4bd6
Compare
Robert-Stam
reviewed
Sep 26, 2024
| rm charts/qdrant-operator-crds/templates/management-crds/*.yaml | ||
| rm charts/qdrant-operator-crds/templates/region-crds/*.yaml | ||
| $(CONTROLLER_GEN) crd paths="./..." output:crd:artifacts:config=charts/qdrant-operator-crds/templates | ||
| mv charts/qdrant-operator-crds/templates/qdrant.io_qdrantversions.yaml charts/qdrant-operator-crds/templates/management-crds/ |
There was a problem hiding this comment.
Maybe not for this PR, but we want to rename QdrantVersion to QdrantRelease
There was a problem hiding this comment.
yup, there is ticket for that.
pedjak
reviewed
Sep 26, 2024
| @@ -20,8 +20,20 @@ gen: manifests generate format vet ## Generate code containing DeepCopy, DeepCop | |||
|
|
|||
| .PHONY: manifests | |||
| manifests: controller-gen ## Generate CustomResourceDefinition objects. | |||
| $(CONTROLLER_GEN) crd paths="./..." output:crd:artifacts:config=charts/qdrant-operator-crds/crds | |||
| cp charts/qdrant-operator-crds/crds/qdrant.io_qdrantversions.yaml charts/qdrant-operator-crds/crds-for-cluster-api/qdrant.io_qdrantversions.yaml | |||
| rm charts/qdrant-operator-crds/templates/management-crds/*.yaml | |||
There was a problem hiding this comment.
do we need to keep them in git repo at all, if everybody just consumes the published chart?
| @@ -20,8 +20,20 @@ gen: manifests generate format vet ## Generate code containing DeepCopy, DeepCop | |||
|
|
|||
| .PHONY: manifests | |||
| manifests: controller-gen ## Generate CustomResourceDefinition objects. | |||
| $(CONTROLLER_GEN) crd paths="./..." output:crd:artifacts:config=charts/qdrant-operator-crds/crds | |||
There was a problem hiding this comment.
these two lines got expanded into 13 lines. I would suggest to move this logic into a script under hack directory, keeping the makefile easier to read and making the script testable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the CRDs are created during
helm installbut they aren't updated.This PR moves them from
crdstotemplatesto solve that.It also introduces a new parameter to control if the
qdrantversionsCRD has to be installed.