Add a meaningful point when 'interior ring not in exterior ring' geometry error is found #62595
Conversation
…ing' geometry error is found (currently, a NULL geometry is passed)
gacarrillor
added
Processing
🪟 Windows buildsDownload Windows builds of this PR for testing. 🍎 MacOS Qt6 buildsDownload MacOS Qt6 builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
|
Can you add a test please? |
| const QgsCurve *interiorRing = polygon->interiorRing( i ); | ||
|
|
||
| if ( interiorRing->numPoints() == 0 ) | ||
| emit errorFound( QgsGeometry::Error( msg ) ); |
There was a problem hiding this comment.
This error will be misleading if interior ring has no points
There was a problem hiding this comment.
True, and that's actually the current behavior.
Nevertheless, QGIS will also find a ring 1 with less than four points error in that case.
In this PR we're just making sure that IF there are points in the interior ring, we do return the starting one.
Currently, when running
native:checkvalidityalgorithm (with the QGIS validation mode) a NULL point is set for such error feature, making it hard to locate.For the same error type, GEOS mode passes the start point of the interior ring.
This PR makes sure QGIS mode also passes the start point of the ring, if any.