add support for SFCGAL library #62611
Conversation
🪟 Windows buildsDownload Windows builds of this PR for testing. 🍎 MacOS Qt6 buildsDownload MacOS Qt6 builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
|
|
||
| find_package(SFCGAL) # SFCGAL provider | ||
| message(STATUS "Found SFCGAL: ${SFCGAL_VERSION} ${SFCGAL_DIR}") | ||
| if(SFCGAL_VERSION VERSION_LESS "2.1") |
There was a problem hiding this comment.
Please lower this to 2.0 -- 2.1 is much too recent (it isn't even available on Fedora 42)
| if(SFCGAL_VERSION VERSION_LESS "2.1") | |
| if(SFCGAL_VERSION VERSION_LESS "2.0") |
There was a problem hiding this comment.
We need at least 2.1 and it is available in rawhide. We still need to change the build stage for fedora 42 and add the rawhide repository only for sfcgal dependencies. It should not impact other dependencies.
There was a problem hiding this comment.
We need at least 2.1 and it is available in rawhide
Can you elaborate why? Rawhide isn't a realistic option.
|
Before merging we'll also need the CI updated so that this new code is built and tested |
src/core/geometry/qgssfcgalengine.h
Outdated
| public: | ||
|
|
||
| /** | ||
| * Creates a SFGAL geometry (inherit QgsAbstractGeometry) from an internal SFCGAL geometry (from SFCGAL library). |
There was a problem hiding this comment.
I meant ALL the docs. I can spot others where the content is misleading -- eg "Same as toAbstractGeometry but returned object is casted to QgsSfcgalGeometry."
| //! Returns the underlying QGIS geometry | ||
| QgsAbstractGeometry *asQgisGeometry( QString *errorMsg = nullptr ) const; |
There was a problem hiding this comment.
unique_ptr return still outstanding
| /** | ||
| * Export the geometry as WKT | ||
| * | ||
| * \param precision Floating point precision for WKT coordinates. Setting to -1 yields rational number WKT (not decimal). |
There was a problem hiding this comment.
That's not actually WKT then, is it? At least the QGIS wkt parser won't accept fraction strings...
This PR is the implementation of this QEP and follow this closed PR.
We add 2 main classes:
The integration in
QgsGeometryclass will be done in a future PR after the geometry backend support is merged.Sponsored by: