-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance improvements #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 Nice set of dependency & code & performance updates!
Please feel free to merge...
Few notes:
- it would be useful to have a small howto for the performance testing tool - how to launch it, what does it do
- would be great to mark in performance.md what was done / not done
- I have realized my Firefox is constantly using 1 full CPU when I have the qgis-js demo open, even if the computer is completely idle otherwise (does that happen to you as well?)
- was there a reason why not stick to emscripten 3.1.37 that is preferred for qt 6.6?
- 1928c39 - I got a bit lost how this is meant to work - I assume the idea is to have the progressive rendering like in QGIS map canvas, right? In my testing, it behaves a bit strangely, but I am not able to explain well why it's that 🙂
- minor typo: Srouce -> Source
- dff9618 - the API was not built to allow starting of jobs in a worker thread - in theory strange things could happen 😄
Hey @wonder-sk, huge thanks for your review 🙏 Feedback to your points:
|
@wonder-sk I observe the same behavior in FF 😟 This needs to be fixed before merging this PR |
@wonder-sk Did some more testing; This is likely something the FF does internally when loading such a large
Unsure what to do with this 🤔 (cc @andreasneumann) |
Will merge this one in and add the Firefox high CPU load as a separate issue: #45 |
Rather large pull request consisting of various performance improvements:
3.1.59
2024.02.14
9.1.0
6.6.1
QgisApi_renderJob
QgisJobDataSrouce.ts
sites/performance
)Ideas and progress tracked in
docs/performance.md