-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API for inserting phi nodes #279
Conversation
I've created a new issue #281 for tracking phi nodes and other bits that are part of adding the core of the adaptive profile support. |
@idavis I'm a little confused by your response, is that a note to self or something actionable on my end? Also, is there a definition of the adaptive profile online? I only know about this Q# documentation, but I was hoping for something analogous to the description of the Base Profile. |
@ausbin Could you please separate the phi node support from the dyn qubits? I like the phi node work. I'm hesitant to add the dyn qubits as the QIR profiles haven't defined what dynamic qubits will look like. Here is the current Adaptive Profile. Using |
Thanks for the link, @idavis. I will take a look. I removed the |
Allows inserting phi nodes and conditional branches. Hopefully addresses #242 and possibly #277
Testing
pytest
passes with a local build of LLVM 14.0.6. I am building with the incantation hereI added a low-effort unit test. If y'all are interested in merging I can put more effort into adding new unit tests (when the giga-test I added fails, the output from pytest is pretty much unreadable)