Skip to content

Introduce output schemas #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Conversation

cesarzc
Copy link

@cesarzc cesarzc commented Oct 25, 2023

This change introduces two output schemas for QIR, ordered and labeled.

@github-actions
Copy link

github-actions bot commented Oct 25, 2023

CLA Assistant Lite bot All Contributors have signed the CLA.

@cesarzc
Copy link
Author

cesarzc commented Oct 25, 2023

I have read the Contributor License Agreement and I hereby accept the Terms.

@cesarzc
Copy link
Author

cesarzc commented Oct 25, 2023

recheck

@cesarzc cesarzc marked this pull request as ready for review November 1, 2023 10:26
Copy link
Contributor

@qartik qartik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the examples for labeled schema all have the incorrect schema name.

Here's an example of the output emitted for a single shot:

```log
HEADER\tschema_name\tordered
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
HEADER\tschema_name\tordered
HEADER\tschema_name\tlabeled

`METADATA` records):

```log
HEADER\tschema_name\tordered
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
HEADER\tschema_name\tordered
HEADER\tschema_name\tlabeled

`METADATA` records):

```log
HEADER\tschema_name\tordered
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
HEADER\tschema_name\tordered
HEADER\tschema_name\tlabeled

`METADATA` records):

```log
HEADER\tschema_name\tordered
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
HEADER\tschema_name\tordered
HEADER\tschema_name\tlabeled

`METADATA` records):

```log
HEADER\tschema_name\tordered
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
HEADER\tschema_name\tordered
HEADER\tschema_name\tlabeled

@qartik qartik mentioned this pull request Jun 6, 2025
@qartik
Copy link
Contributor

qartik commented Jun 17, 2025

I have a PR that forks from this one and adds corrections at #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants