Floating Point Writing Fixes #45
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d also adding the fcmp operation to the spec
dan1pal
approved these changes
Feb 26, 2025
|
@peter-campora When both integer and floating point extensions are enabled, should fptosi and sitofp be available? If not, is there another idiomatic way to convert between the values? |
idavis
approved these changes
May 7, 2025
qartik
reviewed
May 21, 2025
| @@ -696,7 +697,7 @@ additional runtime function must be available: | |||
|
|
|||
| | Function | Signature | Description | | |||
| | :---------------------------------- | :-------------- | :----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | |||
| | __quantum__rt__float_record_output | `void(f64,i8*)` | Records a floating-point value in the generated output. The second parameter defines the string label for the value. Depending on the output schema, the label is included in the output or omitted. | | |||
| | __quantum__rt__float_record_output | `void(double,i8*)` | Records a floating-point value in the generated output. The second parameter defines the string label for the value. Depending on the output schema, the label is included in the output or omitted. | | |||
There was a problem hiding this comment.
Suggested change
| | __quantum__rt__float_record_output | `void(double,i8*)` | Records a floating-point value in the generated output. The second parameter defines the string label for the value. Depending on the output schema, the label is included in the output or omitted. | | |
| | __quantum__rt__double_record_output | `void(double,i8*)` | Records a floating-point value in the generated output. The second parameter defines the string label for the value. Depending on the output schema, the label is included in the output or omitted. | |
If we assume that the idea is to use fpext on smaller floating points and use only __quantum__rt__double_record_output for half, float, and double. It still leaves the question of how to output fp128 type. We may need another RT function for that.
There was a problem hiding this comment.
Alternatively, only 16/32/64-bit floating-point types should be supported.
qartik
reviewed
Jun 6, 2025
| !"float_computations", !"f32,f64"}`. The precision must be one of the LLVM | ||
| recognized values (f16, f32, f64, f80, or f128), and classical computations on | ||
| !"float_computations", !"float,double"}`. The precision must be one of the LLVM | ||
| recognized values (`half (f16)`, `float (f32)`, and `double (f64)`), and classical computations on |
There was a problem hiding this comment.
The backticks should be for the recognized values (types).
Suggested change
| recognized values (`half (f16)`, `float (f32)`, and `double (f64)`), and classical computations on | |
| recognized values (`half` (16-bit), `float` (32-bit), and `double` (64-bit)), and classical computations on |
Alternatively, binary16, binary32 and binary64 in parentheses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing: #41