Skip to content

Conversation

@PositroniumJS
Copy link
Contributor

@PositroniumJS PositroniumJS commented Jan 4, 2025

What are the issues this pull addresses (issue numbers / links)?

Fix #970

Did you add tests to cover your changes (yes/no)?

No need

Did you update the documentation accordingly (yes/no)?

Yes

Did you read the CONTRIBUTING document (yes/no)?

Yes

Summary

  • the folder resonator was not in the installed package because of a missing __init__.py file
  • rename this folder resonator resonators for coherence with the other folders of qlibrary
  • correct some typos

Details and comments

Renaming the folder is a (small) breaking change

Copy link
Collaborator

@zlatko-minev zlatko-minev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked this all runs and works without bugs

@PositroniumJS
Copy link
Contributor Author

PositroniumJS commented Jan 8, 2025

Have you checked this all runs and works without bugs

Now after installation the folder resonators is well installed and showing up in the GUI. If you want to import an element from it you have to change resonator by resonators in the previous imports:
from qiskit_metal.qlibrary.resonators... import ...

The other changes are just typos in comments or documentation, and useless numpy import in two qubits.

@zlatko-minev zlatko-minev merged commit 82e0fc5 into qiskit-community:main Jan 20, 2025
6 of 9 checks passed
@zlatko-minev
Copy link
Collaborator

Thank you, going to assume this work, and double check later. Merging now. Did you look at the massive #1002

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

error on no module name 'qiskit_metal.qlibrary.resonator'

2 participants