Add option --run-in-foreground to qlever start command
#106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qup42
approved these changes
Jan 6, 2025
Collaborator
There was a problem hiding this comment.
The actual changes that I found looked good to me and worked locally. One small note: it might be more intuitive to not redirect the logs to a file if the use case is containers.
The noise made it quite hard to pick out the actual changes though. Maybe we can do a separate PR to format everything tomorrow after finishing #76.
added 5 commits
January 28, 2025 16:18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new option
--run-in-foreground, theqlever startcommand now remains in the foreground as long as the process that runs the QLever server is alive, following the log. Addresses #98