Skip to content

Conversation

@danielpilla
Copy link
Contributor

  • Added schema versioning, so updating the app will not lose qvd history unless the schema changes.

@danielpilla danielpilla requested a review from a team as a code owner December 3, 2024 15:54
@github-actions
Copy link

github-actions bot commented Dec 3, 2024

PR checklist

Checklist:

  • Is the name of this app/solution still App Analyzer?
  • Have you updated the version tag in each .qvf file, and followed semantic versioning (e.g. v1.1.1)?
  • Is this PR named appropriately? For example:
    • Feature release: feat: add sheet usage event
    • Bug fix: fix: replaced deprecated events
    • Documentation update: docs: updated images in install guide
  • Have you reviewed the unbuilt diff generated by the workflow in /diff?

If you wish to merge and release:

  • Have this PR approved by a code owner, then merge into main
  • Go to releases, an action will generate a draft release with all files in /assets, and any external assets references in release.json
  • Make any updates, then submit the release

Common issues:

  • After merging, draft release doesn't update - this is usually because
    the action failed due to an old draft release with the same name.
    Delete the draft release, and re-run the action.

@github-actions
Copy link

PR checklist

Checklist:

  • Is the name of this app/solution still App Analyzer?
  • Have you updated the version tag in each .qvf file, and followed semantic versioning (e.g. v1.1.1)?
  • Is this PR named appropriately? For example:
    • Feature release: feat: add sheet usage event
    • Bug fix: fix: replaced deprecated events
    • Documentation update: docs: updated images in install guide
  • Have you reviewed the unbuilt diff generated by the workflow in /diff?

If you wish to merge and release:

  • Have this PR approved by a code owner, then merge into main
  • Go to releases, an action will generate a draft release with all files in /assets, and any external assets references in release.json
  • Make any updates, then submit the release

Common issues:

  • After merging, draft release doesn't update - this is usually because
    the action failed due to an old draft release with the same name.
    Delete the draft release, and re-run the action.

@danielpilla
Copy link
Contributor Author

Added sheet titles along with the qvd schema variable @withdave. Ready to merge.

@withdave withdave merged commit 700d89c into main Dec 18, 2024
1 check passed
@withdave withdave deleted the feat-v6.4.0 branch December 18, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants