Adding support for MAC and arm machine #107
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnarayanamurthy
requested review from
arbassett-qnx,
chachoi,
JohnAtQNX,
marcin-sochacki,
pkleymonov-qnx,
dchordia,
csinnott-work,
felixlionardo-qnx,
BBOSR,
JaiXJM-BB,
fxing-qnx,
helen-at-qnx and
dphipps-qnx
dchordia
reviewed
Mar 12, 2025
| --net=host \ | ||
| --privileged \ | ||
| -v $HOME:$HOME \ | ||
| -v $HOME:/home/$USER/ \ | ||
| "$QNX_SDP_VERSION:latest" /bin/bash --rcfile /usr/local/qnx/.qnxbashrc |
There was a problem hiding this comment.
rcfile is being loaded during docker exec below so is it needed here?
JohnAtQNX
requested changes
Mar 12, 2025
| @@ -2,8 +2,13 @@ | |||
|
|
|||
| QNX_SDP_VERSION=qnx800 | |||
|
|
|||
| docker run -it \ | |||
| docker create -it --name=qnx-build \ | |||
There was a problem hiding this comment.
Suggest changing the container name here, to avoid conflicting with the one in the repo in gitlab.
Suggested change
| docker create -it --name=qnx-build \ | |
| docker create -it --name=qnx-ports-build \ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have made changes reference with qnx support on MAC reference.
Validated on X64 ubuntu system and trying to validate on ubuntu arm and MAC arm.