Skip to content

Eigen3 install the header to QNX_TARGET #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sohamm17
Copy link

@sohamm17 sohamm17 commented May 2, 2025

In absence of staging location, this PR installs Eigen3 to QNX_TARGET location

@dchordia
Copy link
Contributor

dchordia commented May 2, 2025

Thanks for bringing this up. A simple fix would be to remove the CMAKE_INSTALL_INCLUDEDIR variable in common.mk and it would install to right QNX_TARGET/staging location.

@dchordia
Copy link
Contributor

dchordia commented May 2, 2025

Adding @eleir9268 since he made last changes to build files.

@dchordia dchordia requested review from dchordia and eleir9268 May 2, 2025 10:52
@eleir9268
Copy link
Contributor

We need to clean up these paths in a lot of our ports. AFAIK CMAKE_INSTALL_PREFIX and CMAKE_INSTALL_STAGING are supposed to be the only absolute paths, and CMAKE_INSTALL_*DIR are relative to those prefixes. This can fix issues with relocation.

I'm guessing you took out the CMAKE_STAGING_PREFIX and encountered errors because it tried to install data under /usr/local/share.

@eleir9268
Copy link
Contributor

I would put in a change in common.mk similar to the PR #132 , the README.md change can stay the same.

@sohamm17
Copy link
Author

sohamm17 commented May 3, 2025

I would put in a change in common.mk similar to the PR #132 , the README.md change can stay the same.

Makes sense. Done.

@eleir9268
Copy link
Contributor

If you install to a staging directory without CMAKE_STAGING_PREFIX does the build succeed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants