Skip to content

Port pytorch mobile v1.13.0 for SDP 7.1 #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

eleir9268
Copy link
Contributor

@eleir9268 eleir9268 commented Jan 31, 2025

This PyTorch version compiles with (and supports a version of XNNPACK that compiles with) SDP 7.1.

Tests: All pass except,

./c10_typeid_test
[ RUN      ] TypeMetaTest.Names
/home/eleir/gh_workspace/pytorch/c10/test/util/typeid_test.cpp:32: Failure
Expected equality of these values:
  "nullptr (uninitialized)"
    Which is: 3138b430d0
  null_meta.name()
    Which is: {}
[  FAILED  ] TypeMetaTest.Names (21 ms)

It seems like they expect a dependency object's constructor to be invoked without explicitly invoking it when creating null_meta.

Example at https://gitlab.com/qnx/sample-apps/pytorch_classifier_example also succeeds.

NOTE
Many of the tests and my example code fail to lock a mutex and throw a system error on teardown. It doesn't look like I'm going to have much luck debugging it (it seems like the build manually strips symbols somewhere so I can't get a backtrace).
I also have not tested many of the command line options to pytorch, i.e. BUILD_LITE_INTERPRETER=OFF, TRACING_BASED=ON, USE_LIGHTWEIGHT_DISPATCH=ON

@eleir9268 eleir9268 changed the title Port pytorch mobile v1.7.1 for SDP 7.1 Draft: Port pytorch mobile v1.7.1 for SDP 7.1 Feb 3, 2025
@eleir9268 eleir9268 marked this pull request as draft February 3, 2025 16:30
@eleir9268 eleir9268 changed the title Draft: Port pytorch mobile v1.7.1 for SDP 7.1 Port pytorch mobile v1.13.0 for SDP 7.1 Feb 7, 2025
@eleir9268 eleir9268 self-assigned this Feb 7, 2025
@eleir9268 eleir9268 marked this pull request as ready for review February 7, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants