Added nocodes functionality and removed automations #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suriksarkisyan
commented
Dec 2, 2025
Runtime/Android/Plugins/com/qonversion/unitywrapper/NoCodesWrapper.java
Outdated
Show resolved
Hide resolved
suriksarkisyan
commented
Dec 2, 2025
Comment on lines
+56
to
+59
|
|
||
|
|
||
|
|
||
|
|
Contributor
Author
There was a problem hiding this comment.
Suggested change
suriksarkisyan
commented
Dec 2, 2025
Comment on lines
+44
to
+47
|
|
||
|
|
||
|
|
||
|
|
Contributor
Author
There was a problem hiding this comment.
Suggested change
SpertsyanKM
reviewed
Dec 2, 2025
| { | ||
| if (!(Json.Deserialize(jsonStr) is Dictionary<string, object> screenResult)) | ||
| { | ||
| Debug.LogError("Could not parse NoCodes screen id"); |
Contributor
There was a problem hiding this comment.
Suggested change
| Debug.LogError("Could not parse NoCodes screen id"); | |
| Debug.LogError("Could not parse No-Code Screen id"); |
Comment on lines
+63
to
+84
| case "nocodes_screen_shown": | ||
| case "screen_shown": | ||
| result = NoCodesEventType.ScreenShown; | ||
| break; | ||
| case "nocodes_finished": | ||
| case "finished": | ||
| result = NoCodesEventType.Finished; | ||
| break; | ||
| case "nocodes_action_started": | ||
| case "action_started": | ||
| result = NoCodesEventType.ActionStarted; | ||
| break; | ||
| case "nocodes_action_failed": | ||
| case "action_failed": | ||
| result = NoCodesEventType.ActionFailed; | ||
| break; | ||
| case "nocodes_action_finished": | ||
| case "action_finished": | ||
| result = NoCodesEventType.ActionFinished; | ||
| break; | ||
| case "nocodes_screen_failed_to_load": | ||
| case "screen_failed_to_load": |
Contributor
There was a problem hiding this comment.
Why are keys duplicated? let's syncronize them
| /// <summary> | ||
| /// Event fired when any NoCodes event occurs. | ||
| /// </summary> | ||
| event Action<NoCodesEvent> EventReceived; |
Contributor
There was a problem hiding this comment.
why is it needed, when we have a delegate?
Comment on lines
+23
to
+36
| Task SetScreenPresentationConfig(NoCodesPresentationConfig config, [CanBeNull] string contextKey = null); | ||
|
|
||
| /// <summary> | ||
| /// Shows a NoCodes screen with the specified context key. | ||
| /// </summary> | ||
| /// <param name="contextKey">Context key for the screen to show.</param> | ||
| /// <returns>Task that completes when the screen is shown.</returns> | ||
| Task ShowScreen(string contextKey); | ||
|
|
||
| /// <summary> | ||
| /// Closes the current NoCodes screen. | ||
| /// </summary> | ||
| /// <returns>Task that completes when the screen is closed.</returns> | ||
| Task Close(); |
Contributor
There was a problem hiding this comment.
Why do we use tasks here, not void?
Comment on lines
+16
to
+17
| private const string SdkVersion = "10.0.3"; | ||
| private const string SdkSource = "unity"; |
Contributor
There was a problem hiding this comment.
I don't like duplication of these constants, let's use the ones from QonversionInternal - either move them somewhere or somehow else
Comment on lines
+59
to
+68
| /// <summary> | ||
| /// Simplified initialization method that only requires a project key. | ||
| /// </summary> | ||
| /// <param name="projectKey">Qonversion project key.</param> | ||
| /// <returns>Initialized instance of the NoCodes SDK.</returns> | ||
| public static INoCodes InitializeWithProjectKey(string projectKey) | ||
| { | ||
| var config = new NoCodesConfig(projectKey); | ||
| return Initialize(config); | ||
| } |
| /// <summary> | ||
| /// Builder class for creating NoCodesConfig instances. | ||
| /// </summary> | ||
| public class NoCodesConfigBuilder |
Contributor
There was a problem hiding this comment.
Where is an option to provide a delegate from here?
| /// Sets the delegate for handling NoCodes events. | ||
| /// </summary> | ||
| /// <param name="delegate">Delegate instance for handling NoCodes events.</param> | ||
| public static void SetDelegate(NoCodesDelegate @delegate) |
Contributor
There was a problem hiding this comment.
There shouldn't be a static method for that; it's set either through initialization via config or using the initialized instance.
Comment on lines
+45
to
+47
| unsigned long len = strlen(unityListener); | ||
| noCodesUnityListenerName = malloc(len + 1); | ||
| strcpy(noCodesUnityListenerName, unityListener); |
Contributor
There was a problem hiding this comment.
so strange to see it in 2025 :D
Comment on lines
+53
to
+56
| if (!noCodesSandwich) { | ||
| NSLog(@"Error: NoCodesSandwich not initialized. Call _initializeNoCodes first."); | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
I think these checks here and below are extra, as we are responsible for initialization of the sandwich. If it crashes here, we will see the error during the development, but these checks make the code less readable.
…b.com:qonversion/unity-sdk into ssarkisyan/dev-109-unity-add-no-codes-support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.