Skip to content

ci: switch to AWS container registry #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

sampra2025
Copy link

@sampra2025 sampra2025 commented Jun 10, 2025

As per AWS environment its recommended to use AWS Hosted docker hub instead of Public docker hub such as "docker.io", so updating the container registry.

@sampra2025 sampra2025 requested a review from doanac June 10, 2025 17:49
@sampra2025 sampra2025 self-assigned this Jun 10, 2025
@sampra2025 sampra2025 added the enhancement New feature or request label Jun 10, 2025
Copy link

github-actions bot commented Jun 10, 2025

Test Results

 2 files  ±0   4 suites  ±0   6m 47s ⏱️ ±0s
15 tests ±0  15 ✅ ±0  0 💤 ±0  0 ❌ ±0 
38 runs  ±0  38 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 893ded3. ± Comparison against base commit 523802c.

♻️ This comment has been updated with latest results.

Copy link

Test jobs for commit c1ea40b

@@ -27,7 +27,7 @@ jobs:
url: ${{ steps.upload_artifacts.outputs.url }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github doesn't allow commenting on the commit message but that's the problem with this PR. You need a couple things:

  • subject line
  • body
  • signed-off-by

So something more like:

ci: Switch to AWS container registry

The new CI workers are located in AWS and will benefit a little by using ECR.

Signed-off-by: .....

Copy link

Test jobs for commit c1ea40b

@sampra2025 sampra2025 changed the title For Validating cutover to Production environment CI: Switch to AWS container registry Jun 10, 2025
@sampra2025 sampra2025 assigned sampra2025 and unassigned sampra2025 Jun 10, 2025
@sampra2025 sampra2025 removed the enhancement New feature or request label Jun 10, 2025
The new CI workers are located in AWS and will benefit a little by using ECR.

Signed-off-by: Satish Mhaske <[email protected]>
@sampra2025 sampra2025 changed the title CI: Switch to AWS container registry ci: switch to AWS container registry Jun 10, 2025
Copy link

Test jobs for commit 893ded3

@lool
Copy link
Contributor

lool commented Jun 19, 2025

Hi, sorry just spotting this PR now; thanks Andy for your help in reviewing it!

I have no objection on the technical implementation, but I'd like to capture the specific reasons we're doing this change in this conversation or in the commit message.

You note in the PR message "As per AWS environment its recommended to use AWS Hosted docker hub instead of Public docker hub", and in the commit "The new CI workers are located in AWS and will benefit a little by using ECR".

Both sound like soft requirements and perhaps the latter hints at performance/costs benefits? Could you clarigy if we are doing this for security / best practices reasons from Qualcomm IT, for AWS cost/performance efficiency reasons, or for some other reasons?

I trust the registry will always mirror the latest debian:trixie images. Are all images available there and getting cached/audited somehow, or do I need to request new images I want to use? Is that the same process as for the Qualcomm internal container registry?

(BTW, I was wondering if you've considered implementing a github action that would check whether Qualcomm repositories have workflows that use the new runners and are not using the Elastic Container Registry; we do this to scan commits to make sure they have a signed-off-by and that it's not using a wrong email address for instance.)

@lool
Copy link
Contributor

lool commented Jul 2, 2025

@sampra2025 Not sure you saw my comment above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants