-
Notifications
You must be signed in to change notification settings - Fork 29
add to_object to the vtable and fix numpy "linking" #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
deb4269
ENH: use PyArray_Scalar to convert anyref to object
2b50f30
ENH: add static assertions about sizeof scopedref
8662ab1
BLD: try to clean up how import_array works in the tests
9ec5940
TST: add more context on malloc leaks
e77b7c9
TST: add more context on malloc leaks
102ef8d
DEV: I think these are the same leaks we wanted to supress before but…
2afc87e
ENH: push to_object into the vtable so there is less dispatching in t…
b265313
MAINT: rename LIBPY_MAIN to LIBPY_TEST_MAIN
d9e04e7
DOC: clarify why numpy uses import_array
93b5098
Apply suggestions from code review
22e76c0
DEV: fix make format
312ab39
DOC: update comment
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this just an oversight? I wonder if we could set up a linter of some sort to suggest obvious missing
const
s like this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this just means we don't have a test for this, idk if a linter is the correct tool. These qualifications aren't "obvious" or not, they are part of the API