-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing license files & do minor updates to dot files #7161
Conversation
Apparently I misread guidance somewhere, and license headers are required for these sorts of files after all.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7161 +/- ##
==========================================
- Coverage 98.13% 98.13% -0.01%
==========================================
Files 1093 1093
Lines 95579 95579
==========================================
- Hits 93798 93797 -1
- Misses 1781 1782 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see inline comments.
This removes unnecessary or unused content, in response to review comments on PR quantumlib#7161.
@Pavol the latest update address all the points, but does not add max_line_length yet, pending a resolution to our off-line discussion about what to do with that setting. |
After more discussion, the conclusion is that despite the issues with `max_line_length`, it is handled as expected in the editors that many people have been using.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This patch resolves typescript lint check. The typescript linter looks at max_line_length and if active wants to reformat sources. That can be done later. diff --git a/.editorconfig b/.editorconfig
index 97b035e1..b45c549c 100644
--- a/.editorconfig
+++ b/.editorconfig
@@ -38,4 +38,5 @@ max_line_length = 100
# Google style guidelines use 2.
indent_size = 2
+max_line_length = 0
[*.json]
|
I'm curious: how did you figure this out? |
The typescript linter looks at max_line_length and takes it into account if it finds a value. This is causing CI checks to fail. We need to reformat the sources in question and then we can remove this setting again
I ran |
After discovering this week that Google's requirements for license headers are not what I originally thought (tl;dr: they're actually needed everywhere), I'm going around and adding them to files where I failed to put them before. Poor use of time, but seems necessary.
While at it, for files like
.editorconfig
, I'm updating them slightly to match the conclusions from recent discussions.