return a single results object instead of always a list - IonQ #7285
+86
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cynocracy
approved these changes
Apr 18, 2025
Cynocracy
suggested changes
Apr 18, 2025
Cynocracy
reviewed
Apr 18, 2025
Cynocracy
reviewed
Apr 18, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7285 +/- ##
=======================================
Coverage 98.66% 98.67%
=======================================
Files 1106 1106
Lines 96086 96102 +16
=======================================
+ Hits 94808 94824 +16
Misses 1278 1278 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Cynocracy
suggested changes
Apr 22, 2025
| @@ -296,3 +296,28 @@ def test_service_remote_host_default(): | |||
| def test_service_remote_host_from_env_var_cirq_ionq_precedence(): | |||
| service = ionq.Service(api_key='tomyheart') | |||
| assert service.remote_host == 'http://example.com' | |||
|
|
|||
|
|
|||
| def test_service_run_unwraps_single_result_list(): | |||
There was a problem hiding this comment.
can you add a test for the correctness of the order of multiple results being returned?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ionq results api can return a list of results or a single result, so this change allows for either a list or single element to be returned from the results endpoint