-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update RB to reduce the size of the generated circuits #7411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7411 +/- ##
==========================================
- Coverage 98.68% 98.68% -0.01%
==========================================
Files 1092 1092
Lines 96635 96672 +37
==========================================
+ Hits 95366 95401 +35
- Misses 1269 1271 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Nour!! I tested this, and it works!
Could we also change the default value for use_xy_basis
in cirq.experiments.parallel_single_qubit_randomized_benchmarking
to False, since that is the default value internally? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace _CliffordGateSequence
with a simple conversion.
Otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before merging, see b/422636519
Co-authored-by: Pavol Juhas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with two small adjustments.
… in strict gatesets
1b26b6a
to
cf27bb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Nour! This looks a lot better!
I'm noticing that there is more instance-to-instance fluctuation in the error rates with this implementation than with the internal one. See this colab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the API, thanks Nour!
@eliottrosenberg there are two sources of randomness when running RB, the first is intrinsic that comes from running the circuits on a quantum chip, the second is that everytime the method is run a new set of circuits is generated. the old api which you are using the notebook didn't expose a way to control the circuit generation. the new one does. so if you call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but let's follow up to resolve the remaining discrepancies.
the cirq RB sequences were often 2-3 times bigger than they should, this is because for historical reasons the cliffords were written as products of X/Z or X/Y gates. In this PR I merge these gates into a single PhasedXZGate which is the same as we do internally.