Skip to content

Replace: np.string_ -> np.byte_ #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

JerryChen97
Copy link

Context:

The usage of numpy.string_ caused quite some trouble for users with NumPy 2.x
Hopefully a direct replacement with byte_ can help a little bit.

Copy link

google-cla bot commented Mar 13, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mhucka
Copy link
Contributor

mhucka commented Apr 14, 2025

@JerryChen97 Thank you for this. I'd like to merge the changes, but before that can be done, we need you to sign off on the contributor's license agreement. Could you please check this page and follow the instructions? https://github.com/quantumlib/OpenFermion/pull/1010/checks?check_run_id=38741050105

@mhucka mhucka self-assigned this Apr 14, 2025
@mhucka mhucka added area/dependencies Involves packages or other software that qsim depends on priority/p0 This is urgent and needs to get done ASAP labels Apr 14, 2025
@mhucka mhucka self-requested a review April 14, 2025 01:26
@mhucka mhucka removed the priority/p0 This is urgent and needs to get done ASAP label Apr 14, 2025
@JerryChen97
Copy link
Author

@mhucka Thanks a lot for reminder! I'm right now employee of another company which also features SSO therefore I'm not sure if it is proper for me to directly sign it. But I can sign this on behalf of myself during my after-work time.

@JerryChen97
Copy link
Author

For the CI failures I'll suggest a replacement byte_ -> byte

@loriab loriab mentioned this pull request May 7, 2025
@mhucka
Copy link
Contributor

mhucka commented Jun 2, 2025

Thank you for your efforts. I've worked on NumPy 2 compatibility and this PR is subsumed by new PR #1057. Consequently, I'm going to close this one.

@mhucka mhucka closed this Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Involves packages or other software that qsim depends on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants