Conversation
Collaborator
Author
|
Depends on #342 |
Collaborator
Author
|
@wjhuggins, PTAL at the very minimal README / suggest something more to say. It's not really clear from a cursory scan of the code if there's a useful minimal example to show some useful features of the library. |
Collaborator
Author
|
@mpharrigan PTAL |
fdmalone
commented
Jun 15, 2024
Collaborator
Author
|
@mpharrigan PTAL I migrated it to a top level third_party folder and added a note in the README about the separate installation. |
Collaborator
Author
|
cc @dstrain115 we decided adding the dependency to third_party was probably the best solution |
Collaborator
Author
|
I do not have permission to merge this myself. |
mpharrigan
reviewed
Jun 17, 2024
Comment on lines
+54
to
+57
| - name: Test third_party | ||
| run: | | ||
| pip install pytest | ||
| pytest third_party/quaff |
Collaborator
There was a problem hiding this comment.
you can probably remove this in a following PR when we have tests that exercise the quaff code path. We don't usually run tests for external packages
mpharrigan
approved these changes
Jun 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the quaff dependency. Quite a big commit.