Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QCQMC unit tests and speed up actions #353

Merged
merged 13 commits into from
Jul 1, 2024

Conversation

fdmalone
Copy link
Collaborator

@fdmalone fdmalone commented Jun 28, 2024

Add some unit tests for new files from #347 and speed up CI by setting OMP_NUM_THREADS=1. From experience elsewhere I think pyscf (or openblas) is considerably slower when this is picked up from the environment default (which is use all threads). Brings the CI times down from 13m ~ 6m which is what it was roughly before #347

@fdmalone fdmalone marked this pull request as ready for review June 28, 2024 21:40
@fdmalone fdmalone requested review from dstrain115 and mpharrigan and removed request for dstrain115 June 28, 2024 21:41
Copy link
Collaborator

@dstrain115 dstrain115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Yes, usually CI has poor performance with multi-threading/processing for some reason.

.github/workflows/pythonpackage.yml Outdated Show resolved Hide resolved
@fdmalone fdmalone merged commit e0206d9 into quantumlib:master Jul 1, 2024
5 checks passed
@fdmalone fdmalone deleted the qcqmc-unit-tests branch July 1, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants