Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken markdown link to a notebook #362

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Fix broken markdown link to a notebook #362

merged 3 commits into from
Jul 30, 2024

Conversation

pavoljuhas
Copy link
Contributor

  • Fix notebook filename in markdown link
  • Well behaved text files end with newline
  • Strip tail blanks from markdown files

This fixes broken "Code Overview" link at
https://quantumai.google/cirq/experiments/qcqmc.

@fdmalone fdmalone self-requested a review July 30, 2024 18:19
fdmalone
fdmalone reviewed Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@fdmalone fdmalone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fdmalone fdmalone self-requested a review July 30, 2024 18:32
@fdmalone fdmalone merged commit fcfc513 into quantumlib:master Jul 30, 2024
5 checks passed
@pavoljuhas pavoljuhas deleted the fix-notebook-link branch July 30, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdmalone fdmalone fdmalone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavoljuhas @fdmalone