Adding ReCirq for Lattice Gauge Theory paper accepted to Nature #383

snichet · 2025-04-22T03:32:19Z

In this Recirq Tutorial, I have outlined cirq simulations of the experiments that I conducted as a hardware resident at Google quantum AI. These results are outlined in the arXiv posting https://arxiv.org/abs/2409.17142.

eliottrosenberg

Wow, thanks Tyler!! This is very thorough! I also sent you some very minor comments on the .ipynb notebook.

recirq/lgt_strings/lgt_experiment.py

recirq/lgt_strings/lgt_experiment_test.py

eliottrosenberg · 2025-04-22T04:08:13Z

@dstrain115 I don't have write access to this repo, so maybe you could take a look when you get a chance?

…snichit-lgt

dstrain115

What do you think of "lattice_gauge" instead of "lgt_strings"? It might be easier to figure out what a directory name like that means rather than a guess at the abbreviation.

dstrain115 · 2025-04-23T13:06:08Z

recirq/lgt_strings/lgt_experiment.py

@@ -0,0 +1,1267 @@
+from collections.abc import Iterator, Sequence


Please add copyright and apache declaration. See elsewhere in Recirq for an example.

done in new commit

dstrain115 · 2025-04-23T13:06:16Z

recirq/lgt_strings/lgt_experiment_test.py

@@ -0,0 +1,171 @@
+import cirq


Please add copyright and apache declaration.

done in new commit

dstrain115 · 2025-04-23T13:09:49Z

recirq/lgt_strings/lgt_experiment.py

+
+        Args:
+            a_set: set of input qubits, usually ancillary qubits of a set of plaquettes.
+            qubit1_relationship: either "a", "u", "r", "d", or "l". indicated that the first qubit in each pair will either


Optional: It might be better to have this as an enum rather than a string, but it's not strictly necessary if that's a large change.

done. in new commit I introduce class QubitNeighbor(Enum)

dstrain115 · 2025-04-23T13:14:26Z

recirq/lgt_strings/lgt_experiment.py

+                the qubits in a_set.
+            qubit2_relationship: ... same but the second qubit in each pair.
+        """
+        if qubit1_relationship == "a":


I wonder if it would be better to have a dictionary with some representation that represents the displacement rather than painfully have hundreds of lines of if/then. For instance displacement["a"]["u"] = (0, -1/2) represents no displacement in column but -1/2 displacement in row_vector.

good suggestion. fixed in new commit

dstrain115 · 2025-04-23T13:20:18Z

recirq/lgt_strings/lgt_experiment.py

+def trotter_odd_zcol_entangle_minimal_qubits(
+    grid: LGTGrid, extra_z_plaquette_indices: list[tuple[int, int]] = []
+):
+    """Minimal qubits need not obey device connectivity, used for simulation.


This description could be improved. I am not sure what this function does from this sentence.

fixed in new commit

dstrain115 · 2025-04-23T13:21:00Z

recirq/lgt_strings/lgt_experiment.py

+def trotter_even_xcol_entangle_minimal_qubits(
+    grid: LGTGrid, extra_plaquette_indices: list[tuple[int, int]] = []
+):
+    """Minimal qubits need not obey device connectivity, used for simulation.


Same here. This is the exact same description as the previous function. What's the difference?

fixed in new commit

dstrain115 · 2025-04-23T13:21:11Z

recirq/lgt_strings/lgt_experiment.py

+def trotter_odd_xcol_entangle_minimal_qubits(
+    grid: LGTGrid, extra_plaquette_indices: list[tuple[int, int]] = []
+):
+    """Minimal qubits need not obey device connectivity, used for simulation.


Same description.

fixed in new commit

dstrain115 · 2025-04-23T13:22:05Z

recirq/lgt_strings/lgt_experiment.py

+
+def excitation_sep_plaquette_input(
+    plaq_data: np.ndarray, plaq_rows: int = 3, plaq_cols: int = 2
+) -> np.ndarray:


Missing docstring.

fixed in new commit

dstrain115 · 2025-04-23T13:22:59Z

recirq/lgt_strings/lgt_experiment.py

+import numpy as np
+import sympy
+
+class LGTGrid:


This is a pretty long file. Should we move LGTGrid into its own file?

done in new commit

mhucka · 2025-04-23T20:44:00Z

@dstrain115 Should we assign this PR to you?

snichet · 2025-04-24T03:33:54Z

What do you think of "lattice_gauge" instead of "lgt_strings"? It might be easier to figure out what a directory name like that means rather than a guess at the abbreviation.

Done

dstrain115 · 2025-04-24T14:48:03Z

Thanks for addressing the code comments. I think we are almost there. There are some test failures.

Also, the formatting of the notebook is not correct. I would add the standard header to the ipynb. Also, please remove the sys.path and user-specific things at the beginning. I would also move the big code block before the motivation section. Maybe this could be in a section called "Setup".

snichet · 2025-04-29T04:12:07Z

Thanks for the comments, @dstrain115!

I made the notebook reformatting by moving the setup cells to separate .py files.

I have been trying to use dev_tools/nbfmt to reformat to get the tests to pass. However I keep getting an error when i try to call this function: Installation of tensorflow-docs is broken, please correct. I've tried different python versions and reinstalled it several times. When I run the function a file is populated in dev_tools/tensorflow-docs.txt with the text tensorflow-docs==2025.2.19.33219. Any advice on how to proceed?

dstrain115 · 2025-04-29T12:38:19Z

@mhucka Do you have any tips on how to get nbfmt working for Tyler?

mhucka · 2025-04-30T03:06:22Z

@mhucka Do you have any tips on how to get nbfmt working for Tyler?

Thanks for flagging this. I'll take a look.

dstrain115 · 2025-04-30T12:43:15Z

You still have this in your notebook:

"sys.path.append('/Users/tylerac/Documents/VS_Code_Projects/ReCirq Stuff/ReCirq')"

We should not have references to personal home directories in the public notebook.

snichet · 2025-04-30T15:07:43Z

You still have this in your notebook:

"sys.path.append('/Users/tylerac/Documents/VS_Code_Projects/ReCirq Stuff/ReCirq')"

We should not have references to personal home directories in the public notebook.

Sorry about that. I took it out, and then put it back in for testing reasons after I made updates and just forgot to remove it again. I'll definitely take it out in the next iteration.

mhucka · 2025-05-01T02:10:59Z

@mhucka Do you have any tips on how to get nbfmt working for Tyler?

PR #387 replaces the nbfmt notebook testing script with nbformat taken from Cirq, which is what nbfmt actually used under the hood. Combined with updates to the dependencies, this should work now for testing notebooks.

@snichet After that PR is merged, could you give dev_tools/nbformat a try?

snichet and others added 2 commits April 21, 2025 23:29

adding tests and finishing up notebook

e2af479

Merge branch 'master' into snichit-lgt

c95bf82

eliottrosenberg approved these changes Apr 22, 2025

View reviewed changes

recirq/lgt_strings/lgt_experiment.py Outdated Show resolved Hide resolved

recirq/lgt_strings/lgt_experiment_test.py Outdated Show resolved Hide resolved

snichet added 2 commits April 22, 2025 23:25

nits

9bc33e4

Merge branch 'snichit-lgt' of https://github.com/snichet/ReCirq into …

81f2e84

…snichit-lgt

dstrain115 reviewed Apr 23, 2025

View reviewed changes

Doug comments

e3bf8e4

snichet requested a review from dstrain115 April 24, 2025 03:34

Doug notebook reformats

6e0a1d4

remove path cell

8b0d923

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding ReCirq for Lattice Gauge Theory paper accepted to Nature #383

Adding ReCirq for Lattice Gauge Theory paper accepted to Nature #383

snichet commented Apr 22, 2025

eliottrosenberg left a comment

eliottrosenberg commented Apr 22, 2025

dstrain115 left a comment

dstrain115 Apr 23, 2025

snichet Apr 24, 2025

dstrain115 Apr 23, 2025

snichet Apr 24, 2025

dstrain115 Apr 23, 2025

snichet Apr 24, 2025

dstrain115 Apr 23, 2025

snichet Apr 24, 2025

dstrain115 Apr 23, 2025

snichet Apr 24, 2025

dstrain115 Apr 23, 2025

snichet Apr 24, 2025

dstrain115 Apr 23, 2025

snichet Apr 24, 2025

dstrain115 Apr 23, 2025

snichet Apr 24, 2025

dstrain115 Apr 23, 2025

snichet Apr 24, 2025

mhucka commented Apr 23, 2025

snichet commented Apr 24, 2025

dstrain115 commented Apr 24, 2025

snichet commented Apr 29, 2025

dstrain115 commented Apr 29, 2025

mhucka commented Apr 30, 2025

dstrain115 commented Apr 30, 2025

snichet commented Apr 30, 2025 •

edited

Loading

mhucka commented May 1, 2025

		@@ -0,0 +1,1267 @@
		from collections.abc import Iterator, Sequence

Adding ReCirq for Lattice Gauge Theory paper accepted to Nature #383

Are you sure you want to change the base?

Adding ReCirq for Lattice Gauge Theory paper accepted to Nature #383

Conversation

snichet commented Apr 22, 2025

eliottrosenberg left a comment

Choose a reason for hiding this comment

eliottrosenberg commented Apr 22, 2025

dstrain115 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mhucka commented Apr 23, 2025

snichet commented Apr 24, 2025

dstrain115 commented Apr 24, 2025

snichet commented Apr 29, 2025

dstrain115 commented Apr 29, 2025

mhucka commented Apr 30, 2025

dstrain115 commented Apr 30, 2025

snichet commented Apr 30, 2025 • edited Loading

mhucka commented May 1, 2025

snichet commented Apr 30, 2025 •

edited

Loading