Remove the constraint that stim.Tableau.from_state_vector inputs must be normalized #840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strilanc
requested changes
Oct 1, 2024
Collaborator
Strilanc
left a comment
Strilanc
left a comment
There was a problem hiding this comment.
Yeah this is basically the functionality that's desired, but a few more tests and pushing it down into the C++ are needed.
drqec
force-pushed
the
normalize-state-vectors
branch
2 times, most recently
from
d4468ba to
75d9bde
Compare
drqec
force-pushed
the
normalize-state-vectors
branch
from
75d9bde to
c9607db
Compare
Strilanc
approved these changes
Oct 9, 2024
Collaborator
|
Thanks for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just taking a stab at fixing #638. Note, I don't fully understand how Tableau should work but I wrote the tests based on the examples, so I think this should be correct.
from_state_vectorincluding an unnormalized version