Skip to content

Fix exception when sampling with post-selection #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix exception when sampling with post-selection #844

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
485c0d8
Exclude discarded shots when asserting decoder prediction size
cesarBLG Oct 22, 2024
d81c4aa
Add unit test for detector post-selection sampling
cesarBLG Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions glue/sample/src/sinter/_decoding/_stim_then_decode_sampler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,8 +197,8 @@ def sample(self, max_shots: int) -> AnonTaskStats:
raise ValueError("predictions.dtype != np.uint8")
if len(predictions.shape) != 2:
raise ValueError("len(predictions.shape) != 2")
if predictions.shape[0] != num_shots:
raise ValueError("predictions.shape[0] != num_shots")
if predictions.shape[0] != num_shots - num_discards_1:
raise ValueError("predictions.shape[0] != num_shots - num_discards_1")
if predictions.shape[1] < actual_obs.shape[1]:
raise ValueError("predictions.shape[1] < actual_obs.shape[1]")
if predictions.shape[1] > actual_obs.shape[1] + 1:
Expand Down