You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This does a minor cleanup of a few issues with `CMakeLists.txt`:
* Remove references to variable `PYMATCHING_SOURCE_FILES_NO_MAIN`. This
variable is not defined anywhere in Chromobius and does not exist in
Pymatching, so as far as I can tell, its value is always empty and thus
has no effect in this `CMakeLists.txt` file.
* Set variable `CHROMOBIUS_VERSION_INFO` from `setup.py`. Previously,
the `CMakeLists.txt` file had this in it:
```cmake
add_compile_definitions(CHROMOBIUS_VERSION_INFO=${CHROMOBIUS_VERSION_INFO})
```
However, the variable on the RHS (`${CHROMOBIUS_VERSION_INFO}`) is not
set when CMake is processing the file. This PR changes it to extract the
version number from the `setup.py` file.
* Wrap long lines and normalize indentation to 4 spaces.
Copy file name to clipboardExpand all lines: CMakeLists.txt
+35-15Lines changed: 35 additions & 15 deletions
Original file line number
Diff line number
Diff line change
@@ -56,28 +56,30 @@ if(NOT GTest_FOUND)
56
56
message(STATUS"GTest fetch successful.")
57
57
set(GTest_FOUND TRUE)
58
58
else()
59
-
message("WARNING: Failed to get GTest. Some tests will not be built. To fix, follow the Standalone CMake Project install instructions at https://github.com/google/googletest/blob/master/googletest/README.md")
59
+
message(WARNING "Failed to find GoogleTest. Some tests will not be built. To fix "
60
+
"this, follow the Standalone CMake Project install instructions for GTest "
message("WARNING: Skipped chromobius_pybind target. `pybind11` not found. To fix, install pybind11. On debian based distributions, the package name is `pybind11-dev`")
160
+
message(WARNING "Skipped target 'chromobius_pybind' because `pybind11` could not be found. "
161
+
"To fix this, install pybind11. On Debian and Ubuntu Linux distributions, the "
162
+
"package name is 'pybind11-dev'. For other systems, please see the pybind11 "
163
+
"instructions at https://pybind11.readthedocs.io/.")
0 commit comments