-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/firebase realtime database #724
base: main
Are you sure you want to change the base?
Feature/firebase realtime database #724
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there real need for a Firebase Database extension? Isn't the existing Firestore extension already sufficient?
@@ -0,0 +1,76 @@ | |||
= Google Cloud Services - Firebase Admin | |||
|
|||
This extension allows to inject a `com.google.cloud.firestore.Firestore` object inside your Quarkus application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This didn't seems to be accurate as Firestore is from a different extension
@@ -37,7 +37,7 @@ public class FirebaseDevServiceProcessor { | |||
FirebaseEmulatorContainer.Emulator.FIREBASE_HOSTING, "quarkus.google.cloud.firebase.hosting.emulator-host", | |||
FirebaseEmulatorContainer.Emulator.CLOUD_FUNCTIONS, "quarkus.google.cloud.functions.emulator-host", | |||
FirebaseEmulatorContainer.Emulator.EVENT_ARC, "quarkus.google.cloud.eventarc.emulator-host", | |||
FirebaseEmulatorContainer.Emulator.REALTIME_DATABASE, "quarkus.google.cloud.database.emulator-host", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it a backward incompatible change?
Fixes #133