Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/firebase realtime database #724

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jfbenckhuijsen
Copy link
Contributor

@jfbenckhuijsen jfbenckhuijsen commented Dec 20, 2024

Fixes #133

@jfbenckhuijsen jfbenckhuijsen marked this pull request as ready for review January 3, 2025 14:20
@jfbenckhuijsen jfbenckhuijsen requested a review from a team as a code owner January 3, 2025 14:20
Copy link
Collaborator

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there real need for a Firebase Database extension? Isn't the existing Firestore extension already sufficient?

@@ -0,0 +1,76 @@
= Google Cloud Services - Firebase Admin

This extension allows to inject a `com.google.cloud.firestore.Firestore` object inside your Quarkus application.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This didn't seems to be accurate as Firestore is from a different extension

@@ -37,7 +37,7 @@ public class FirebaseDevServiceProcessor {
FirebaseEmulatorContainer.Emulator.FIREBASE_HOSTING, "quarkus.google.cloud.firebase.hosting.emulator-host",
FirebaseEmulatorContainer.Emulator.CLOUD_FUNCTIONS, "quarkus.google.cloud.functions.emulator-host",
FirebaseEmulatorContainer.Emulator.EVENT_ARC, "quarkus.google.cloud.eventarc.emulator-host",
FirebaseEmulatorContainer.Emulator.REALTIME_DATABASE, "quarkus.google.cloud.database.emulator-host",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it a backward incompatible change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add support for firebase realtime database
2 participants