Skip to content

[#22] Support Quarkus Cache #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2025
Merged

[#22] Support Quarkus Cache #35

merged 1 commit into from
May 21, 2025

Conversation

karesti
Copy link
Contributor

@karesti karesti commented May 5, 2025 •
edited
Loading

Closes #16
Closes #22

@karesti karesti changed the title Cache SPI implementation [#22] Support Quarkus Cache May 5, 2025
@karesti karesti force-pushed the implement-cache-spy branch 5 times, most recently from c64add9 to ffe023f Compare May 6, 2025 15:31
@karesti
Copy link
Contributor Author

karesti commented May 6, 2025

@maxandersen this will be ready soon, I hope

@karesti karesti force-pushed the implement-cache-spy branch 2 times, most recently from d72e3fb to 99191cc Compare May 6, 2025 17:22
@karesti karesti requested a review from wburns May 6, 2025 17:22
@karesti karesti force-pushed the implement-cache-spy branch from 99191cc to 7765ba7 Compare May 7, 2025 08:52
@karesti karesti marked this pull request as ready for review May 7, 2025 08:53
@karesti karesti requested a review from a team as a code owner May 7, 2025 08:53
@karesti karesti force-pushed the implement-cache-spy branch 6 times, most recently from 03c5869 to dac0ac5 Compare May 7, 2025 12:12
wburns
wburns reviewed May 7, 2025
View reviewed changes
Copy link

@wburns wburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am half way through the review, will try to get to the rest tomorrow

wburns
wburns reviewed May 8, 2025
View reviewed changes
Copy link

@wburns wburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last bit of review.

@karesti
Copy link
Contributor Author

karesti commented May 12, 2025

@wburns I'll leave the handleAndCompose for two reasons: casting of the bifunction and redability: I know that more async stuff is going on when I use that method in the top. I discussed with @jabolina and looks a harmless use

@karesti karesti force-pushed the implement-cache-spy branch 2 times, most recently from 0bbf064 to 3486369 Compare May 13, 2025 09:13
@karesti
Copy link
Contributor Author

karesti commented May 13, 2025

@wburns I reported all, please merge if you are ok with the PR

@karesti karesti added the enhancement New feature or request label May 13, 2025
@wburns
Copy link

wburns commented May 20, 2025

Sorry for the delay, it looks like the review comments that are hidden were overlooked.

@karesti karesti force-pushed the implement-cache-spy branch from 7094903 to 438d892 Compare May 21, 2025 11:03
@karesti
[quarkiverse#22] Quarkus Cache implementation
afad45a 
* Includes quarkiverse#16 with the @Embedded cache annotation
* Docs added for persistence example
* Local persistence sample
* Caching annotations sample
@karesti karesti force-pushed the implement-cache-spy branch from 438d892 to afad45a Compare May 21, 2025 11:54
@wburns wburns merged commit 4a57de3 into quarkiverse:main May 21, 2025
1 check passed
@wburns
Copy link

wburns commented May 21, 2025

Integrated into main, thanks @karesti !

@karesti karesti deleted the implement-cache-spy branch May 22, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wburns wburns wburns left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Quarkus Cache Add injection of Caches
2 participants
@karesti @wburns