Skip to content

ci: Change the Rust CI job to work on Linux, Windows and MacOS #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 4, 2025

Conversation

whiskeyo
Copy link
Contributor

No description provided.

Copy link
Collaborator

@NothNoth NothNoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NothNoth
Copy link
Collaborator

NothNoth commented Jun 2, 2025

It seems there's a conflict with the last merged PR, can you fix it?
Thanks!

@whiskeyo whiskeyo force-pushed the rust-cross-platform-build branch from 1eea1f7 to 5e13bf0 Compare June 2, 2025 20:57
@whiskeyo
Copy link
Contributor Author

whiskeyo commented Jun 2, 2025

It seems there's a conflict with the last merged PR, can you fix it? Thanks!

Hello, conflicts are now fixed. I was pretty annoyed on both branches with the missing ** and I removed a comment on one branch, forgot to remove it on the other. Otherwise it would probably work out of the box with the rebase :D

@NothNoth
Copy link
Collaborator

NothNoth commented Jun 4, 2025

Perfect, thanks !

@NothNoth NothNoth merged commit f628e8f into quarkslab:main Jun 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants