Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply idea code analysis suggestions P-Security #2193

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Apply idea code analysis suggestions P-Security #2193

merged 1 commit into from
Nov 15, 2024

Conversation

mocenas
Copy link
Contributor

@mocenas mocenas commented Nov 14, 2024 •
edited by gtroitsk
Loading

Summary

Apply idea code analysis tips to modules P-Security. Mostly updating deprecated API usages, removing unused things and code simplification.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@mocenas
Copy link
Contributor Author

mocenas commented Nov 14, 2024

run tests

@mocenas
Copy link
Contributor Author

mocenas commented Nov 15, 2024

OCP failure is in a module which is not changed in this PR. Also seems to be just a fluke with image pulling.
So failure unrelated.

gtroitsk
gtroitsk approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@gtroitsk gtroitsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you. OCP CI was triggered before and failures were unrelated. Let's wait for GH CI and merge

@michalvavrik michalvavrik merged commit 78c9775 into quarkus-qe:main Nov 15, 2024
7 checks passed
@mocenas mocenas deleted the codestyle_changes_P-security branch November 15, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtroitsk gtroitsk gtroitsk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mocenas @gtroitsk @michalvavrik