Shared extension for the Hibernate Search Elasticsearch backend

[yrodiere]

To reduce code duplication.

Opening as draft, because:

• It's based on Refresh documentation (and some tests) of the Hibernate Search + ORM extension #39413 and Extension for the Hibernate Search Standalone Pojo Mapper with Elasticsearch #39415, which must be merged first. => Done
• It requires Rework how configuration doc generation works #35439 to get fixed first, and that will take a while; see https://quarkusio.zulipchat.com/#narrow/stream/187038-dev/topic/Reusing.20ConfigMapping.20from.20other.20JARS => Done

Based on #43943, which must be merged first. => Done

[quarkus-bot]

/cc @gsmet (hibernate-search)

[yrodiere]

Rebased on main. Ran a few tests locally, and it seems to be working fine... we'll need to check the generated documentation for configuration properties though.

[marko-bekhta]

This is a nice improvement! 😃
There are a couple of failing tests because of the missing pu-config, I'll let you decide how you want to address those 😃. Other than that, it looks good!

[yrodiere]

Thanks for your comments @marko-bekhta , I think I addressed most of them.

Now, the failure to generate documentation is actually more serious than it seemed... I started working on a potential solution, but in essence we're lacking some features in Quarkus docs generation. I'll try to discuss this with Guillaume, see #43808 for details (or don't, and save your time for something more interesting xD).

[github-actions]

🎊 PR Preview 7ab2138 has been successfully built and deployed to https://quarkus-pr-main-39416-preview.surge.sh/version/main/guides/

• Images of blog posts older than 3 months are not available.
• Newsletters older than 3 months are not available.

[yrodiere]

#43943 was merged, I rebased on main, so I think we're all set.

@marko-bekhta I think I addressed your comments, do you mind approving please?

[marko-bekhta]

🎉

[gsmet]

I'll have a look later today.

[gsmet]

Sorry for the very late review. I added only one (annoying, sorry...) comment. I think it would be worth taking it into account even if I know you won't be very excited about it :).

[yrodiere]

I renamed the extension to quarkus-hibernate-search-backend-elasticsearch-common as requested.

[quarkus-bot]

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 1c43f90.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 1c43f90.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

---

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 integration-tests/oidc-client-wiremock

✖ io.quarkus.it.keycloak.OidcClientTest.testGetAccessTokenWithConfiguredExpiresIn - History

• expected: <true> but was: <false> - org.opentest4j.AssertionFailedError

Details

org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183)
	at io.quarkus.it.keycloak.OidcClientTest.testGetAccessTokenWithConfiguredExpiresIn(OidcClientTest.java:60)

[gsmet]

I somehow forgot about this one...

[yrodiere]

No harm done: so did I... :)