print error in tests when reading project fails

[gordonwoodhull]

cc @cderv

When the project is invalid in a playwright test, the actual error is not printed. It just prints

Playwright tests are passing ... FAILED (1m56s)

 ERRORS 

Playwright tests are passing => ./integration/playwright-tests.test.ts:60:6
error: Error: Failed to read quarto project YAML
    throw new Error("Failed to read quarto project YAML", error);
          ^
    at findProjectOutputDir (file:///home/runner/work/quarto-cli/quarto-cli/tests/utils.ts:55:11)
    at outputForInput (file:///home/runner/work/quarto-cli/quarto-cli/tests/utils.ts:81:36)
    at cleanoutput (file:///home/runner/work/quarto-cli/quarto-cli/tests/smoke/render/render.ts:93:15)
    at fn (file:///home/runner/work/quarto-cli/quarto-cli/tests/integration/playwright-tests.test.ts:81:9)

It doesn't seem that the actual error makes it into the playwright report either.

I'm not sure if the second parameter to new Error() is valid; according to MDN it should be {cause: error}.

I tried this but still I could not find the actual error, so I suggest printing it instead.

What do you think?

(Background: I am new to Quarto projects, and quarto render will succeed if the project does not have project.type, but tests will fail. I think it would be good if the error messages indicate the actual problem.)

[cderv]

Ok I'll have a look in that. Thanks

[cderv]

You're right this is not correct

It should be this, right ?

Suggested change

	throw new Error("Failed to read quarto project YAML", error);
	throw new Error("Failed to read quarto project YAML\n" + error);

This would show the error wouldn't it ? No need for a previous console.log ?
Or are you saying we need because playwright hide the error ?

[gordonwoodhull]

Looking at this more carefully, it looks like what happens is the documents still render properly and tests succeed, but then it dies in a cleanup task, only printing the stack trace but not the error.

Because we're not in Playwright at this point (I think?) the error doesn't go into the Playwright logs.

It might be better to improve the error as you say, and then catch it somewhere further up the call stack and print it there.