Detect if device is in dark mode or not#17672
Open
diadal wants to merge 2 commits intoquasarframework:devfrom
Open
Detect if device is in dark mode or not#17672diadal wants to merge 2 commits intoquasarframework:devfrom
diadal wants to merge 2 commits intoquasarframework:devfrom
Conversation
|
|
||
| if (__QUASAR_SSR_SERVER__) { | ||
| this.isActive = dark === true | ||
| this.isPreferred = matchMedia.matches |
Member
There was a problem hiding this comment.
Adding @rstoenescu's comment from here:
https://github.com/quasarframework/quasar/pull/17670/changes#r1865970342
There is no matchMedia here, nor can it be. This code runs on the server. It should be defaulted to a value (probably
false) and updated only on client takeover, otherwise there will be hydration errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
devbranch (orv[X]branch)fix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
this helps to know if the device is in dark mode or not