chore: upgrade ansible ee to support ansible-core 2.16+ #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: syntaxsdev <[email protected]>
HammerMeetNail
added
the
ok-to-test
|
@syntaxsdev Thanks for the PR! I just kicked off the testing, we should be able to get this in pretty easily if everything passes. |
HammerMeetNail
approved these changes
Mar 21, 2025
HammerMeetNail
added
ok-to-test
|
@HammerMeetNail Thanks for your reply. It seems like 2 of the tests are failing at the remote install but probably unrelated to the image change. Could we rerun these again or are we ok to merge? |
|
/cherry-pick mirror-registry-2.0-rhel-8 |
|
@bcaton85: new pull request created: #192 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #187
should close: #155
On systems with Python 3.12+ and higher, for some reason (even with the EE encompassing its own version) the mirror-registry command fails at the last steps to wait for the host to be live, despite the actual service being up and usable.
This is caused to due to deprecations in parameters for Python3.12 + in the
urllib3orrequestslibraries, causing the timeout to wait 3 minutes because of a parameter failure and them timeouts, causing workflows depending on the success/zero exit code to fail as well.It is imperative that the base images are updated, as I have tried this across 20+ automated VM installs with many different versions of the library, it seems that this is the only fix (upgrading to Ansible 2.16+.)
I tested with
make build-online-zipon a fresh server install.