Expose shutdown lifecycle on ChitchatHandle #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -144,18 +146,23 @@ pub async fn spawn_chitchat( | |||
| let chitchat_arc = Arc::new(Mutex::new(chitchat)); | |||
| let chitchat_arc_clone = chitchat_arc.clone(); | |||
|
|
|||
| let (termination_watcher_sender, termination_watcher) = watch::channel(None); | |||
There was a problem hiding this comment.
Suggested change
| let (termination_watcher_sender, termination_watcher) = watch::channel(None); | |
| let (termination_watcher_sender, termination_watcher) = watch::channel(None); |
I think that codebase adopts the _tx for sender and _rx for receiver naming scheme.
It is confusing, but common in rust.
| @@ -186,6 +199,20 @@ impl ChitchatHandle { | |||
| self.command_tx.send(Command::Gossip(addr))?; | |||
| Ok(()) | |||
| } | |||
|
|
|||
| pub fn termination_watcher(&self) -> impl Future<Output = anyhow::Result<()>> { | |||
| let mut watcher = self.termination_watcher.clone(); | |||
There was a problem hiding this comment.
an alternative implementation could have been to add a deps to the futures crate and rely on future::shared() over the JoinHandle.
fulmicoton-dd
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To handle chitchat failures and panics in QW, we need to be able to watch its state (quickwit-oss/quickwit#5819)