Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid index_id with ingest v2 returns 429 #5721

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rdettai
Copy link
Collaborator

@rdettai rdettai commented Mar 25, 2025

Description of the issue

When using index templates, specifying and index name that matches the pattern but has illegal characters results in a 429 response code instead of a 400.

Description of the problem:

  • the index_id validity is not validated until the metastore is called
  • calling GetOrCreateOpenShards with an invalid index_id on the metastore fails with MetastoreError::JsonDeserializeError
  • a failure to call the metastore is logged but not repported to the ingest workbench
  • because the router is not populated, the workbench fails with "shard not found errors" for the failing index but also other targetted indexes batched with it

Proposed solution

The index id is now validated in quickwit-serve, before calling the ingest router (ES bulk and native APIs)

How was this PR tested?

Added unit and integration (python) tests

@rdettai rdettai self-assigned this Mar 25, 2025
@rdettai rdettai requested a review from guilload March 25, 2025 15:30
@rdettai rdettai changed the title Failure to create an index with ingest v2 returns 429 Invalid index_id with ingest v2 returns 429 Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant