Invalid index_id with ingest v2 returns 429 #5721
Merged
Conversation
rdettai
changed the title
guilload
approved these changes
Apr 9, 2025
| ) | ||
| })?; | ||
|
|
||
| // Validate index id early because propagating back the right error (400) |
Member
There was a problem hiding this comment.
Suggested change
| // Validate index id early because propagating back the right error (400) | |
| // Validate index ID early because propagating back the right error (400) |
| // from deeper ingest layers is harder | ||
| if validate_identifier("", &index_id).is_err() { | ||
| return Err(IngestServiceError::BadRequest( | ||
| "invalid index_id".to_string(), |
Member
There was a problem hiding this comment.
Suggested change
| "invalid index_id".to_string(), | |
| "invalid index ID".to_string(), |
rdettai
force-pushed
the
fix-invalid-index-id-code
branch
from
ab3a96d to
0106709
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue
When using index templates, specifying and index name that matches the pattern but has illegal characters results in a 429 response code instead of a 400.
Description of the problem:
GetOrCreateOpenShardswith an invalid index_id on the metastore fails with MetastoreError::JsonDeserializeErrorProposed solution
The index id is now validated in
quickwit-serve, before calling the ingest router (ES bulk and native APIs)How was this PR tested?
Added unit and integration (python) tests