feat(obs): export internal logs with otlp exporter#6142
Open
Totodore wants to merge 3 commits intoquickwit-oss:mainfrom
Open
feat(obs): export internal logs with otlp exporter#6142Totodore wants to merge 3 commits intoquickwit-oss:mainfrom
Totodore wants to merge 3 commits intoquickwit-oss:mainfrom
Conversation
Collaborator
ncoiffier-celonis
left a comment
ncoiffier-celonis
left a comment
There was a problem hiding this comment.
I would love to see this PR merged.
quickwit/quickwit-cli/src/main.rs
Outdated
| .context("failed to shutdown OpenTelemetry tracer provider")?; | ||
| logs_provider | ||
| .shutdown() | ||
| .context("failed to shutdown OpenTelemetry tracer provider")?; |
Collaborator
There was a problem hiding this comment.
Minor typo: failed to shutdown OpenTelemetry tracer provider -> failed to shutdown OpenTelemetry log provider
Contributor
Author
|
@guilload done! |
Member
|
You're missing this: https://github.com/DataDog/rust-license-tool See also CONTRIBUTING.md. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently quickwit only export its traces, this change also export internal logs if the
QW_ENABLE_OPENTELEMETRY_OTLP_EXPORTERis set to true.This is particularly important in a production env when we want to have structured logs to monitor quickwit and find root cause for quickwit internal errors.
How was this PR tested?
otel-logs-v0_9as expected.Side note
We may want to put another env config to disable this behavior by default.
We may also want to configure custom batching behavior according to the log volume (something that I'm not particularly aware of).