Skip to content

Miscellaneous cleanup #1581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ralith merged 10 commits into from
Jun 3, 2023
Merged

Miscellaneous cleanup #1581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9d4307f
Reduce ConnectionId copying
Ralith May 28, 2023
c929727
Fix obsolete debug struct name
Ralith May 28, 2023
cc587c3
Fix invalid CIDs being ignored when using zero-length CIDs
Ralith May 28, 2023
bce3263
Remove redundant/obsolete Endpoint::reject_new_connections
Ralith May 28, 2023
b8ca753
Factor connection lookup out into a dedicated struct
Ralith May 28, 2023
146ec8a
Move ConnectionHandle into DatagramEvent
Ralith Jun 3, 2023
114a991
Yield endpoint-generated responses directly rather than buffering
Ralith Jun 3, 2023
d713fd4
Allocate persistent connection IDs immediately when generated
Ralith May 28, 2023
99dbf93
Rename issue_cids to issue_first_cids to better reflect its role
Ralith May 29, 2023
e0aff66
Bump versions to reflect API breakage
Ralith Jun 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion quinn-proto/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "quinn-proto"
version = "0.10.1"
version = "0.11.0"
edition = "2021"
rust-version = "1.63"
license = "MIT OR Apache-2.0"
Expand Down
8 changes: 4 additions & 4 deletions quinn-proto/src/connection/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2292,7 +2292,7 @@ impl Connection {
.push_back(EndpointEventInner::ResetToken(self.path.remote, token));
}
self.handle_peer_params(params)?;
self.issue_cids(now);
self.issue_first_cids(now);
} else {
// Server-only
self.spaces[SpaceId::Data].pending.handshake_done = true;
Expand Down Expand Up @@ -2339,7 +2339,7 @@ impl Connection {
reason: "transport parameters missing".into(),
})?;
self.handle_peer_params(params)?;
self.issue_cids(now);
self.issue_first_cids(now);
self.init_0rtt();
}
Ok(())
Expand Down Expand Up @@ -2794,8 +2794,8 @@ impl Connection {
self.peer_params.stateless_reset_token = Some(reset_token);
}

/// Issue an initial set of connection IDs to the peer
fn issue_cids(&mut self, now: Instant) {
/// Issue an initial set of connection IDs to the peer upon connection
fn issue_first_cids(&mut self, now: Instant) {
if self.local_cid_state.cid_len() == 0 {
return;
}
Expand Down
Loading