refactor!: rename log feature to tracing-log #1930
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `quinn*` would provide the `log` feature to log events via `log` if no `tracing` subscriber exists. Later quinn-rs#1923 allowed `quinn-udp` to log via `log` directly, making `tracing` an optional dependency. For that, it introduced the `direct-log` feature, a workaround name in order to not introduce a breaking change. This commit cleans up the above, renaming the `log` feature to `tracing-log` and the `direct-log` to `log`. This is a breaking change and thus `quinn-udp` is bumped to `v0.6.0`. See quinn-rs#1921 for the full history.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
quinn*would provide thelogfeature to log events vialogif notracingsubscriber exists.Later #1923 allowed
quinn-udpto log vialogdirectly, makingtracingan optional dependency. For that, it introduced thedirect-logfeature, a workaround name in order to not introduce a breaking change.This commit cleans up the above, renaming the
logfeature totracing-logand thedirect-logtolog. This is a breaking change and thusquinn-udpis bumped tov0.6.0.See #1921 for the full history.
Only merge before the next breaking change of
quinn.I am opening this up early as it is (a) still fresh in my mind, (b) in order to keep track of it and (c) make the next breaking change easier. Feel free to close if you don't think it is useful.