Use Async::new_nonblocking to avoid redundant socket configuration
#2077
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces Quinn's use of
Async::newwithAsync::new_nonblocking, a constructor introduced in version 2.0 ofasync_io, which assumes the socket has already been put into non-blocking mode. For Quinn this is indeed the case, asquinn_udpconfigures the socket as non-blocking already.As for the Tokio runtime implementation, that uses
UdpSocket::from_std, which already makes this assumption.