feat(quinn-proto): unhide quinn_proto::coding
#2078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ralith
requested changes
Dec 10, 2024
Collaborator
Ralith
left a comment
Ralith
left a comment
There was a problem hiding this comment.
The idea of exposing this seems reasonable. Some cosmetic feedback to help with clarity.
djc
reviewed
Dec 11, 2024
Collaborator
|
Worth noting that this is not the most minimal possible way to export |
Ralith
approved these changes
Dec 12, 2024
djc
approved these changes
Dec 12, 2024
Member
|
Can you squash these commits? |
It turned out currently the `coding` mod is already public, simply hidden from the docs. It seems to be the minimal change to allow using this functionality for `VarInt` is to document it and not hide it. Fixes quinn-rs#1277
dignifiedquire
force-pushed
the
feat-varint-coding
branch
from
2c96a72 to
4aabf4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turned out currently the
codingmod is already public, simply hidden from the docs.It seems to be the minimal change to allow using this functionality for
VarIntis to document it and not hide it.Fixes #1277