refactor(quinn-udp): split fast&slow send/recv paths #2472
+95
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larseggert
requested review from
Ralith,
djc,
gretchenfrage and
mxinden
as code owners
Member
|
Can you rebase this and get CI passing? |
Separate the fast path (`msghdr_x`-based) and slow path (`msghdr`-based) implementations to prepare for runtime dispatch between them. Broken out of quinn-rs#2463 as suggested by @djc.
larseggert
force-pushed
the
refactor/split-send-recv-paths
branch
from
e9bb301 to
e9350d0
Compare
djc
approved these changes
Jan 22, 2026
Contributor
|
I haven't tested the feasibility of this idea but I am wondering at what point it will be simpler to not just split the code in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate the fast path (
msghdr_x-based) and slow path (msghdr-based) implementations to prepare for runtime dispatch between them.Broken out of #2463 as suggested by @djc.