Skip to content

Conversation

@DSharifi
Copy link

closes #2422

@gretchenfrage
Copy link
Collaborator

Thank you!

Our MSRV policy is not to bump the MSRV to a version less than 6 months old. extract_if was stabilized in Rust 1.91.0, which was released Oct/30/2025. So if this PR is merged before Apr/30/2026, it will have to be put behind a feature gate.

@DSharifi
Copy link
Author

Thank you!

Our MSRV policy is not to bump the MSRV to a version less than 6 months old. extract_if was stabilized in Rust 1.91.0, which was released Oct/30/2025. So if this PR is merged before Apr/30/2026, it will have to be put behind a feature gate.

Yes, discussing the MSRV also came up in the issue it closes #2422 (comment)

I'm happy with keeping it as a draft until May next year, but I can also create a feature gated version if you prefer that :)

@djc
Copy link
Member

djc commented Dec 29, 2025

The policy is not to bump until the MSRV is at least 6 months old, but we've mostly been more conservative, sort of matching up with tokio's MSRV. So if you want this anytime soon, feature gating is probably the better option.

@DSharifi DSharifi changed the title chore(proto): use extract_if in RangeSet for better performance perf(proto): use extract_if in RangeSet for better performance Dec 29, 2025
@gretchenfrage
Copy link
Collaborator

Unless you or someone really wants this soon, I think we can leave it a draft for now :)

@DSharifi
Copy link
Author

Personally, I don't mind keeping it in draft.

Let me know what you guys decide. For now I added a change to feature gate the changes with the rustversion crate. If we keep it feature gated, we'd need to also update CI to run these unit tests with +1.91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

proto: Leverage BTreeMap::extract_if in RangeSet for better performance

3 participants