Bugfix/admin timeouts #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-quix
force-pushed
the
bugfix/admin-timeouts
branch
from
afb295d to
fdce20c
Compare
tim-quix
force-pushed
the
bugfix/admin-timeouts
branch
from
fdce20c to
e56a95c
Compare
daniil-quix
approved these changes
May 21, 2024
tim-quix
force-pushed
the
bugfix/admin-timeouts
branch
from
44f302e to
7d3b603
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added timeout arguments across all REST API calls and provided a way to set them from the
Applicationlevel.There are 2 options,
request_timeoutandtopic_create_timeout(which is more of a wait/validation step vs actual request timeout).lowest level API defaults were kept where possible (ex if Confluent Kafka AdminClient
list_topicshas -1 timeout, ourTopicAdminuses that as default for it'slist_topics), but for the most part those defaults are overridden by a parent class (ex.TopicAdminwill always receivetimeoutarguments fromTopicManager, which is ultimately set by theApplicationclass setting.in terms of tests, made sure that if one API call called another that the corresponding
timeoutwas passed down correctly. Most of the additions are just making suretimeoutwas actually included in the arguments.