Skip to content

Configure the producer flush timeout with the max.poll.interval.ms #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jun 6, 2024

closes #381

Add a configuration option to set a default flush timeout on producers. This ensure the application is not blocked if messages can't be delivered successfully.

consumer.commit doesn't explicitly support a timeout parameter but rely on a globally configured timeout (probably socket.timeout, TBC).

@ghost ghost force-pushed the quent/checkpoint-timeout branch 2 times, most recently from 924526b to 316b2b3 Compare June 7, 2024 14:17
@ghost ghost changed the title Add option to configure the producer flush timeout Configure the producer flush timeout with the max.poll.interval.ms Jun 7, 2024
@ghost ghost force-pushed the quent/checkpoint-timeout branch 2 times, most recently from e729cea to 4672227 Compare June 10, 2024 11:36
@ghost ghost marked this pull request as ready for review June 10, 2024 11:37
Copy link
Collaborator

@daniil-quix daniil-quix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @quentin-quix , looks good overall.
There are only a few minor things to address 👍

@ghost ghost force-pushed the quent/checkpoint-timeout branch from 4672227 to 8c4278a Compare June 13, 2024 09:23
@ghost ghost force-pushed the quent/checkpoint-timeout branch from 8c4278a to aac7221 Compare June 13, 2024 09:26
@ghost ghost requested a review from daniil-quix June 13, 2024 09:48
@daniil-quix daniil-quix merged commit 8acaf75 into main Jun 13, 2024
4 checks passed
@daniil-quix daniil-quix deleted the quent/checkpoint-timeout branch June 13, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set timeouts in the Checkpoint
2 participants