TDengine Sink #931
Open
TDengine Sink #931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-quix
requested changes
Jun 24, 2025
There was a problem hiding this comment.
Added some comments =)
Also note as a last piece, we typically add a doc in the docs/connectors/sinks folder, which outlines additional details on how the sink works, plus how to run tdengine locally for testing purposes (Let me know if you want what I did for that since I also used it for testing... happy to give you it!).
Feel free to copy another doc and make changes as needed.
tim-quix
reviewed
Jun 24, 2025
enh: enhance subtable handling and improve database status checks
|
I added a documentation page. We are done with changes. Please let me know if i missed anything. |
fix: update database status check
tim-quix
previously requested changes
Jul 1, 2025
tim-quix
reviewed
Jul 1, 2025
add noqs ref
remove unused string format
remove internal field assignment, change a couple staticmethods to classmethods
add missing cls argument
fix ruff noqa
fix arguments
fix args...again!
tim-quix
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the table naming template variable