Handle valid_from=None in configuration version selection #946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovv
force-pushed
the
ovv/lookup-quix-config-service-valid-from
branch
from
7179514 to
5cc2844
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ovv
force-pushed
the
ovv/lookup-quix-config-service-valid-from
branch
from
c7129e5 to
fff3b4f
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the configuration version handling to treat configurations with a None valid_from value as always valid. Key changes include updates to the event parsing in ConfigurationVersion.from_event, modifications in the version selection logic in find_valid_version and _find_versions to properly handle None values, and extensive tests to cover these scenarios.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_quixstreams/test_dataframe/test_joins/test_lookup_quix_config.py | Added tests covering scenarios with valid_from set to None and various timestamp boundary cases |
| quixstreams/dataframe/joins/lookups/quix_configuration_service/models.py | Updated type annotations and logic in from_event, find_valid_version, and _find_versions to handle valid_from=None |
Comments suppressed due to low confidence (2)
quixstreams/dataframe/joins/lookups/quix_configuration_service/models.py:325
- Consider adding a comment here to clarify that the early return is intentional when a version with no valid_from is encountered, meaning it is considered always valid and no further previous or next version is needed.
return previous_version, current_version, next_version
quixstreams/dataframe/joins/lookups/quix_configuration_service/models.py:150
- Update the method-level docstring in from_event to explicitly state that when valid_from is None, the resulting configuration version is treated as always valid per the new selection logic.
if raw_valid_from is None:
…ive tests - Refactor Configuration.find_valid_version and _find_versions to handle edge cases - Add tests the quix configuration service lookup
ovv
force-pushed
the
ovv/lookup-quix-config-service-valid-from
branch
from
fff3b4f to
24bedb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A configuration with
valid_from=Noneis always valid