-
Notifications
You must be signed in to change notification settings - Fork 70
Add quantum phase estimation in the list of algorithms #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@BoxiLi is there a controlled U operator in QuTiP? |
You can define a controlled gate object and add the object qutip-qip/src/qutip_qip/operations/gateclass.py Lines 970 to 993 in d58a82d
|
@BoxiLi this is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good! Thanks a lot!
You can run black
on qpe.py
and test_qpe.py
to clean the style. Codeclimate may have some additional complain such as trailing white space. You don't have to clean all of the code climate issues, if some of them become too tedious or irrelevant to the changes.
There are some inconsistencies in the last change. Should be easy fix, other than that I believe this is ready to be merged. |
Done @BoxiLi ! |
Thanks! @rochisha0 |
Adding quantum phase estimation in the list of algorithms. Issue #264