AccountMigration: Improve and fix migration of MIX channels #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnjX
reviewed
Oct 8, 2024
lnjX
reviewed
Oct 8, 2024
lnjX
reviewed
Oct 8, 2024
pasnox
force-pushed
the
fix/migration-manager
branch
2 times, most recently
from
9041fa3
to
9c7f0fd
Compare
melvo
reviewed
Oct 13, 2024
melvo
reviewed
Oct 13, 2024
melvo
reviewed
Oct 13, 2024
melvo
reviewed
Oct 13, 2024
pasnox
force-pushed
the
fix/migration-manager
branch
from
9c7f0fd
to
78a05b8
Compare
lnjX
reviewed
Oct 21, 2024
lnjX
reviewed
Oct 21, 2024
lnjX
reviewed
Oct 21, 2024
lnjX
reviewed
Oct 21, 2024
lnjX
reviewed
Oct 21, 2024
|
QXmppMovedManager: Fix doxygen missing documentation I fixed this on master now without using QXmppClient::EmptyResult. The alias |
pasnox
force-pushed
the
fix/migration-manager
branch
4 times, most recently
from
1e1ee0e
to
e69f349
Compare
Can you change the commit description so that it properly describes the changes (not just "more utils"), e.g. |
Please include that this is only about data import/export in the commit description. And in the long description you could note what is actually fixed. |
lnjX
approved these changes
Oct 28, 2024
pasnox
force-pushed
the
fix/migration-manager
branch
from
2a38fc1
to
08a918d
Compare
lnjX
force-pushed
the
fix/migration-manager
branch
2 times, most recently
from
0a7b4fd
to
ee6252f
Compare
The id is returned (if found).
The original xmlToDom now uses xmlToDomDoc under the wood.
Some tests are more complex and involve inner tasks in between calls and the test client does not handle that great, leading to iq id clash and random iq id generation which make tests unreliable. This is especially visible when a test involve many expect/inject calls like in the migration manager tests.
The QXmppExportData class store data in an unordered_map and would then serialize each extensions in a random order, which break string based unit tests. We then serialize in the std::type_index sorting order.
It can filter and convert items into a given output container.
Originally we only stored the roster as is in the QXmppRosterManager without taking care of MIX channels. This change split the handling of data, QXmppMixManager now export/import the MIX roster items taking care to join again those channels later while QXmppRosterManager now export/import non MIX roster items.
Packets are found no matter in what order they were sent. The IQ IDs are ignored while comparing.
lnjX
force-pushed
the
fix/migration-manager
branch
from
ee6252f
to
0beb4aa
Compare
lnjX
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR check list:
\since QXmpp 1.X,QXMPP_EXPORTdoc/doap.xmlclang-format -i src/<edited-file(s)> tests/<edited-file(s)>Fixed a bunch of issues in the QXmppAccountMigrationManager: